[ISSUE #7334] registerIncrementBrokerData for single topic update
#7335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #7335 +/- ##
=============================================
+ Coverage 42.65% 42.68% +0.02%
Complexity 9466 9466
=============================================
Files 1152 1150 -2
Lines 82726 82724 -2
Branches 10780 10785 +5
=============================================
+ Hits 35286 35308 +22
+ Misses 43028 43004 -24
Partials 4412 4412
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ziy1-Tan
changed the title
Ziy1-Tan
changed the title
registerIncrementBrokerData for single topic update
RongtongJin
reviewed
Sep 10, 2023
There was a problem hiding this comment.
It would better to consider singleTopicRegister.
if (brokerController.getBrokerConfig().isEnableSingleTopicRegister()) {
his.brokerController.registerSingleTopicAll(topicConfig);
} else {
this.brokerController.registerIncrementBrokerData(topicConfig, dateVersion);
}
…date Signed-off-by: Ziy1-Tan <[email protected]>
RongtongJin
approved these changes
Sep 11, 2023
|
I think it's better to abstract to a method |
|
Could you submit a pr to do this? :-) @joeCarf |
Of course, I'd love to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7334
Brief Description
How Did You Test This Change?